Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128039 / 25.04 / Disable toggle for SMB authentication for built-in users #10870

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Oct 14, 2024

Changes:

Disables SMB User checkbox for built-in users.

@undsoft undsoft requested a review from a team as a code owner October 14, 2024 16:34
@undsoft undsoft requested review from bvasilenko and removed request for a team October 14, 2024 16:34
@bugclerk bugclerk changed the title NAS-128039: Disable toggle for SMB authentication for built-in users NAS-128039 / 25.04 / Disable toggle for SMB authentication for built-in users Oct 14, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (f777b2f) to head (31be2ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10870   +/-   ##
=======================================
  Coverage   81.79%   81.80%           
=======================================
  Files        1588     1588           
  Lines       55082    55086    +4     
  Branches     5805     5807    +2     
=======================================
+ Hits        45055    45062    +7     
+ Misses      10027    10024    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, no regressions found

@undsoft undsoft merged commit 21d6958 into master Oct 16, 2024
13 checks passed
@undsoft undsoft deleted the NAS-128039 branch October 16, 2024 08:40
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants