Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131065 / 25.04 / Remove switch to https link #10869

Merged
merged 1 commit into from
Oct 15, 2024
Merged

NAS-131065 / 25.04 / Remove switch to https link #10869

merged 1 commit into from
Oct 15, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Oct 14, 2024

Changes:

Removes switch to https link as requested in the ticket.

@undsoft undsoft requested a review from a team as a code owner October 14, 2024 16:24
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team October 14, 2024 16:24
@bugclerk bugclerk changed the title NAS-131065: Remove switch to https link NAS-131065 / 25.04 / Remove switch to https link Oct 14, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (f777b2f) to head (9e8c93c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10869   +/-   ##
=======================================
  Coverage   81.79%   81.80%           
=======================================
  Files        1588     1588           
  Lines       55082    55076    -6     
  Branches     5805     5805           
=======================================
- Hits        45055    45054    -1     
+ Misses      10027    10022    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a text now, as expected 👌

@undsoft undsoft merged commit 751868c into master Oct 15, 2024
12 of 13 checks passed
@undsoft undsoft deleted the NAS-131065 branch October 15, 2024 09:19
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants