NAS-131766 / 25.04 / Refactor dashboard and other modules to standalone #10854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
+ Coverage 81.78% 81.90% +0.11%
==========================================
Files 1590 1592 +2
Lines 55168 55551 +383
Branches 5817 5817
==========================================
+ Hits 45119 45498 +379
- Misses 10049 10053 +4 ☔ View full report in Codecov by Sentry. |
AlexKarpov98
approved these changes
Oct 15, 2024
| @@ -38,49 +38,6 @@ import { systemInfoPassiveWidget } from 'app/pages/dashboard/widgets/system/widg | |||
| import { systemImageWidget } from 'app/pages/dashboard/widgets/system/widget-system-image/widget-system-image.definition'; | |||
| import { systemUptimeWidget } from 'app/pages/dashboard/widgets/system/widget-system-uptime/widget-system-uptime.definition'; | |||
|
|
|||
| export const widgetComponents = [ | |||
There was a problem hiding this comment.
We have README.md (src/app/pages/dashboard/widgets/README.md) with non working example: 👇
- Connect widget definition to
widgetComponentsandwidgetRegistry.
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
Test affected places.