Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-131693 / 25.04 / Make any required UI repo changes to account for removing option from pool.dataset endpoint #10841

Merged
merged 1 commit into from
Oct 10, 2024
Merged

NAS-131693 / 25.04 / Make any required UI repo changes to account for removing option from pool.dataset endpoint #10841

merged 1 commit into from
Oct 10, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Code review is enough.

@AlexKarpov98 AlexKarpov98 self-assigned this Oct 10, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner October 10, 2024 12:01
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and undsoft and removed request for a team October 10, 2024 12:01
@bugclerk bugclerk changed the title NAS-131693: Make any required UI repo changes to account for removing option from pool.dataset endpoint NAS-131693 / 25.04 / Make any required UI repo changes to account for removing option from pool.dataset endpoint Oct 10, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-131693

undsoft
undsoft approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
We can avoid backporting it as there are no visible UI changes.

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (931c42e) to head (8ab0600).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #10841   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files        1584     1584           
  Lines       54052    54048    -4     
  Branches     5795     5794    -1     
=======================================
- Hits        44081    44080    -1     
+ Misses       9971     9968    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit b2ba129 into master Oct 10, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-131693 branch October 10, 2024 15:52
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft undsoft approved these changes

@RehanY147 RehanY147 Awaiting requested review from RehanY147 RehanY147 is a code owner automatically assigned from truenas/ui-team

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @bugclerk @undsoft