Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131565 / 24.10.0 / Use circle icons for start and stop actions (by denysbutenko) #10828

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Oct 9, 2024

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 4ffd9741617bdbfa63967c81b1a53f2bea614a68

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x b034c975b658bb103c1c4c02134c71317d5dbadc

Changes:

Update icons and added text for actions column

Testing:

Check installed apps or other affected places.

Downstream

Affects Reasoning
Documentation Icons has changed

Original PR: #10827
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131565

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

…S-131565-24.10.0

# Conflicts:
#	src/assets/i18n/ga.json
@undsoft undsoft marked this pull request as ready for review October 10, 2024 11:16
@undsoft undsoft requested a review from a team as a code owner October 10, 2024 11:16
@undsoft undsoft requested review from denysbutenko and removed request for a team October 10, 2024 11:16
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@d752456). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10828   +/-   ##
=====================================================
  Coverage                      ?   79.94%           
=====================================================
  Files                         ?     1570           
  Lines                         ?    51325           
  Branches                      ?     5921           
=====================================================
  Hits                          ?    41033           
  Misses                        ?    10292           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit f9fb973 into stable/electriceel Oct 10, 2024
9 checks passed
@undsoft undsoft deleted the NAS-131565-24.10.0 branch October 10, 2024 12:14
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants