NAS-131245: UI obscures error messages (#11081)

truenas · Nov 23, 2024 · 9748769 · 9748769
1 parent 1c845c9
commit 9748769
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/app/interfaces/api-error.interface.ts b/src/app/interfaces/api-error.interface.ts
@@ -8,6 +8,7 @@ export interface ApiError {
   reason: string;
   trace: ApiErrorTrace;
   type: ResponseErrorType | null;
+  message?: string | null;
 }
 
 export interface ApiErrorTrace {

diff --git a/src/app/services/websocket/api.service.ts b/src/app/services/websocket/api.service.ts
@@ -163,7 +163,7 @@ export class ApiService {
 
   private printError(error: ApiError, context: { method: string; params: unknown }): void {
     if (error.errname === ApiErrorName.NoAccess) {
-      console.error(`Access denied to ${context.method} with ${context.params ? JSON.stringify(context.params) : 'no params'}`);
+      console.error(`Access denied to ${context.method} with ${context.params ? JSON.stringify(context.params) : 'no params'}. Original message: ${error.message}`);
       return;
     }
 
@@ -180,7 +180,7 @@ export class ApiService {
     if (error.errname === ApiErrorName.NoAccess) {
       return {
         ...error,
-        reason: this.translate.instant('Access denied to {method}', { method: context.method }),
+        reason: error.message || this.translate.instant('Access denied to {method}', { method: context.method }),
       };
     }
     return error;