Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130790 / 25.04 / Validate default values exist in the enum specified in the schema #55

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Qubad786
Copy link
Contributor

@Qubad786 Qubad786 commented Oct 1, 2024

Problem

We are missing validation in the case when default values are not present in the enum options.

Solution

Implement validation to ensure that default values are included within the enum options.

@Qubad786 Qubad786 requested a review from a team October 1, 2024 18:05
@bugclerk bugclerk changed the title Validate default values exist in the enum specified in the schema NAS-130790 / 25.04 / Validate default values exist in the enum specified in the schema Oct 1, 2024
@bugclerk
Copy link

bugclerk commented Oct 1, 2024

@Qubad786 Qubad786 merged commit 5e61a05 into master Oct 2, 2024
2 checks passed
@Qubad786 Qubad786 deleted the NAS-130790 branch October 2, 2024 10:54
@bugclerk
Copy link

bugclerk commented Oct 2, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants