Skip to content

Commit

Permalink
Add a todo statement
Browse files Browse the repository at this point in the history
  • Loading branch information
sonicaj committed May 6, 2024
1 parent d379905 commit 4668be2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions apps_validation/validation/app_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ def validate_app_version_file(
'Configured version in "app.yaml" does not match version directory name.'
)

# TODO: Validate train and lib version please

else:
verrors.add(schema, 'Missing app version file')

Expand Down
1 change: 0 additions & 1 deletion apps_validation/validation/validate_templates.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def validate_library(app_path: str, schema: str, verrors: ValidationErrors) -> N
library_contents = list(library_dir.iterdir())
if not library_contents:
return
# TODO: Validate lib version in app.yaml is correct and reflects reality on filesystem
elif len(library_contents) > 2:
verrors.add(schema, 'Library directory should only contain library version from the catalog or the app')

Expand Down

0 comments on commit 4668be2

Please sign in to comment.