tfy-agent: remove default nodeoptions and increase memory (#831)

truefoundry · Nov 28, 2024 · a29d95f · a29d95f
1 parent 71db7a1
commit a29d95f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/charts/tfy-agent/README.md b/charts/tfy-agent/README.md
@@ -102,7 +102,7 @@ If your control plane URL is using self-signed CA certificate, follow these step
 | `config.prometheus.endpoint`             | Endpoint to connect to prometheus                                                                                   | `http://prometheus-operated.prometheus.svc.cluster.local:9090`                   |
 | `config.alertURL`                        | Truefoundry alert URL                                                                                               | `https://auth.truefoundry.com`                                                   |
 | `config.nodeEnv`                         |                                                                                                                     | `production`                                                                     |
-| `config.nodeOptions`                     | Node options for tfyAgent                                                                                           | `--max-old-space-size=250`                                                       |
+| `config.nodeOptions`                     | Node options for tfyAgent                                                                                           | `""`                                                                             |
 | `config.allowedNamespaces`               | A list of namespaces the control plane will have access to for namespaced resources.                                | `[]`                                                                             |
 | `imagePullSecrets`                       | Secrets to pull images                                                                                              | `[]`                                                                             |
 | `nameOverride`                           | String to override partial name passed in helm install command                                                      | `""`                                                                             |
@@ -129,10 +129,10 @@ If your control plane URL is using self-signed CA certificate, follow these step
 | `tfyAgent.image.pullPolicy`                     | Pull policy for tfyAgent                                                                                              | `IfNotPresent`                             |
 | `tfyAgent.image.tag`                            | Overrides the image tag whose default is the chart appVersion.                                                        | `abdd060d96379a09bed4d6c2ab7516a11e154bfa` |
 | `tfyAgent.resources.limits.cpu`                 | CPU resource limits for tfyAgent container. Advised to only increase the limits and not decrease it                   | `500m`                                     |
-| `tfyAgent.resources.limits.memory`              | Memory Resource limits for tfyAgent container. Advised to only increase the limits and not decrease it                | `512Mi`                                    |
+| `tfyAgent.resources.limits.memory`              | Memory Resource limits for tfyAgent container. Advised to only increase the limits and not decrease it                | `1024Mi`                                   |
 | `tfyAgent.resources.limits.ephemeral-storage`   | Ephemeral storage Resource limits for tfyAgent container. Advised to only increase the limits and not decrease it     | `256Mi`                                    |
 | `tfyAgent.resources.requests.cpu`               | CPU resource requests for tfyAgent container. Advised to only increase the requests and not decrease it               | `300m`                                     |
-| `tfyAgent.resources.requests.memory`            | Memory Resource requests for tfyAgent container. Advised to only increase the requests and not decrease it            | `256Mi`                                    |
+| `tfyAgent.resources.requests.memory`            | Memory Resource requests for tfyAgent container. Advised to only increase the requests and not decrease it            | `512Mi`                                    |
 | `tfyAgent.resources.requests.ephemeral-storage` | Ephemeral storage Resource requests for tfyAgent container. Advised to only increase the requests and not decrease it | `128Mi`                                    |
 | `tfyAgent.livenessProbe.failureThreshold`       | Failure threshhold value for liveness probe of tfyAgent container                                                     | `5`                                        |
 | `tfyAgent.livenessProbe.httpGet.path`           | Path for http request for liveness probe of tfyAgent container                                                        | `/`                                        |

diff --git a/charts/tfy-agent/templates/tfy-agent-deployment.yaml b/charts/tfy-agent/templates/tfy-agent-deployment.yaml
@@ -52,8 +52,10 @@ spec:
               value: {{ .Values.config.alertURL | quote }}
             - name: NODE_ENV
               value: {{ .Values.config.nodeEnv | quote }}
+            {{- if .Values.config.nodeOptions }}
             - name: NODE_OPTIONS
               value: {{ .Values.config.nodeOptions | quote }}
+            {{- end }}
             - name: WORKLOAD_NAMESPACE
               value: {{ .Release.Namespace | quote }}
             - name: CLUSTER_TOKEN

diff --git a/charts/tfy-agent/values.yaml b/charts/tfy-agent/values.yaml
@@ -60,7 +60,7 @@ config:
   nodeEnv: production
 
   ## @param config.nodeOptions Node options for tfyAgent
-  nodeOptions: "--max-old-space-size=250"
+  nodeOptions: ""
 
   ## @param config.allowedNamespaces A list of namespaces the control plane will have access to for namespaced resources.
   ## If this list is empty, the control plane can access namespaced resources cluster-wide.
@@ -187,11 +187,11 @@ tfyAgent:
   resources:
     limits:
       cpu: 500m
-      memory: 512Mi
+      memory: 1024Mi
       ephemeral-storage: 256Mi
     requests:
       cpu: 300m
-      memory: 256Mi
+      memory: 512Mi
       ephemeral-storage: 128Mi
 
   ## @param tfyAgent.livenessProbe.failureThreshold Failure threshhold value for liveness probe of tfyAgent container