Update image reference (#802)

* [CI] Update tfy-agent chart values.yaml * Separate out image reference * Update values.yaml * Update values.yaml * Update README.md with readme-generator-for-helm Signed-off-by: DeeAjayi <[email protected]> --------- Signed-off-by: DeeAjayi <[email protected]> Co-authored-by: DeeAjayi <[email protected]>
truefoundry · Nov 20, 2024 · 6b3df8d · 6b3df8d
1 parent fd69655
commit 6b3df8d
Show file tree

Hide file tree

Showing 7 changed files with 87 additions and 80 deletions.
diff --git a/charts/tfy-agent/values.yaml b/charts/tfy-agent/values.yaml
@@ -25,8 +25,7 @@ config:
   ## @param config.controlPlaneClusterIP ClusterIP of the control plane to connect agent (format: `http://`)
   ##
   controlPlaneClusterIP: "http://truefoundry-truefoundry-frontend-app.truefoundry.svc.cluster.local:5000"
-
-   ## @param config.controlPlaneControllerClusterIP ClusterIP of the control plane controller to connect proxy (format: `http://`)
+  ## @param config.controlPlaneControllerClusterIP ClusterIP of the control plane controller to connect proxy (format: `http://`)
   ##
   controlPlaneControllerClusterIP: "http://truefoundry-tfy-controller.truefoundry.svc.cluster.local:8123"
 
@@ -73,8 +72,8 @@ config:
   #   - default
   #   - namespace-1
 
-## @param imagePullSecrets Secrets to pull images
-##
+  ## @param imagePullSecrets Secrets to pull images
+  ##
 imagePullSecrets: []
 
 ## @param nameOverride String to override partial name passed in helm install command
@@ -141,7 +140,7 @@ tfyAgent:
     ## @param tfyAgent.service.port Port for tfyAgent service
     ##
     port: 3000
-    
+
     ## @param tfyAgent.service.nodePort Port to expose on each node. Only used if service.type is 'NodePort'
     ##
     nodePort: ""
@@ -447,8 +446,8 @@ tfyAgentProxy:
     #   resources: ["namespaces"]
     #   verbs: ["create"]
 
-## @section resourceQuota Add a ResourceQuota to enable priority class in a namspace.
-##
+    ## @section resourceQuota Add a ResourceQuota to enable priority class in a namspace.
+    ##
 resourceQuota:
   ## @param resourceQuota.enabled Create the ResourceQuota.
   enabled: true

diff --git a/charts/tfy-inferentia-operator/README.md b/charts/tfy-inferentia-operator/README.md
@@ -12,15 +12,16 @@ Refer to,
 
 ### Configuration for the device plugin responsible for node feature discovery
 
-| Name                                     | Description                                    | Value                                                  |
-| ---------------------------------------- | ---------------------------------------------- | ------------------------------------------------------ |
-| `devicePlugin.enabled`                   | Enable device plugin Daemonset.                | `true`                                                 |
-| `devicePlugin.resources.requests.cpu`    | CPU request for device plugin Daemonset.       | `100m`                                                 |
-| `devicePlugin.resources.requests.memory` | Memory request for device plugin Daemonset.    | `128Mi`                                                |
-| `devicePlugin.image`                     | Image to use for device plugin Daemonset.      | `public.ecr.aws/neuron/neuron-device-plugin:2.16.18.0` |
-| `imagePullSecrets`                       | (global) List of image pull secrets            | `[]`                                                   |
-| `devicePlugin.imagePullSecrets`          | List of image pull secrets                     | `[]`                                                   |
-| `devicePlugin.affinity`                  | Affinity settings for device plugin Daemonset. | `{}`                                                   |
+| Name                                     | Description                                          | Value                                        |
+| ---------------------------------------- | ---------------------------------------------------- | -------------------------------------------- |
+| `devicePlugin.enabled`                   | Enable device plugin Daemonset.                      | `true`                                       |
+| `devicePlugin.resources.requests.cpu`    | CPU request for device plugin Daemonset.             | `100m`                                       |
+| `devicePlugin.resources.requests.memory` | Memory request for device plugin Daemonset.          | `128Mi`                                      |
+| `devicePlugin.image.repository`          | Image repository to use for device plugin Daemonset. | `public.ecr.aws/neuron/neuron-device-plugin` |
+| `devicePlugin.image.tag`                 | Image tag to use for device plugin Daemonset.        | `2.16.18.0`                                  |
+| `imagePullSecrets`                       | (global) List of image pull secrets                  | `[]`                                         |
+| `devicePlugin.imagePullSecrets`          | List of image pull secrets                           | `[]`                                         |
+| `devicePlugin.affinity`                  | Affinity settings for device plugin Daemonset.       | `{}`                                         |
 
 ### Configuration for the scheduler responsible for scheduling neuron pods
 

diff --git a/charts/tfy-inferentia-operator/templates/neuron-device-plugin.yaml b/charts/tfy-inferentia-operator/templates/neuron-device-plugin.yaml
@@ -88,7 +88,7 @@ spec:
       affinity:
         {{- toYaml (index .Values "devicePlugin" "affinity") | nindent 8 }}
       containers:
-      - image: {{ .Values.devicePlugin.image }}
+      - image: {{ .Values.devicePlugin.image.repository }}:{{ .Values.devicePlugin.image.tag }}
         imagePullPolicy: Always
         name: neuron-device-plugin
         resources:

diff --git a/charts/tfy-inferentia-operator/values.yaml b/charts/tfy-inferentia-operator/values.yaml
@@ -2,7 +2,8 @@
 ## @param devicePlugin.enabled Enable device plugin Daemonset.
 ## @param devicePlugin.resources.requests.cpu CPU request for device plugin Daemonset.
 ## @param devicePlugin.resources.requests.memory Memory request for device plugin Daemonset.
-## @param devicePlugin.image Image to use for device plugin Daemonset.
+## @param devicePlugin.image.repository Image repository to use for device plugin Daemonset.
+## @param devicePlugin.image.tag Image tag to use for device plugin Daemonset.
 ## @param imagePullSecrets (global) List of image pull secrets
 ## @param devicePlugin.imagePullSecrets List of image pull secrets
 ## @param devicePlugin.affinity [object] Affinity settings for device plugin Daemonset.
@@ -13,7 +14,9 @@ devicePlugin:
     requests:
       cpu: 100m
       memory: 128Mi
-  image: public.ecr.aws/neuron/neuron-device-plugin:2.16.18.0
+  image:
+    repository: public.ecr.aws/neuron/neuron-device-plugin
+    tag: 2.16.18.0
   imagePullSecrets: []
   tolerations:
     ## @skip devicePlugin.tolerations[0]