-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdownのレンダリング周りをリファクタリングする #105
Draft
trpfrog
wants to merge
20
commits into
main
Choose a base branch
from
refactor-blog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@/app/blog/_renderer
を整理して@/app/blog/_components
と@/markdown
に分割@/app/blog/_components/article-parts
を整理して@/markdown/code-block-components
に移動カスタムコンポーネントの定義方法の変更
こんな感じで定義できるようにした。Render Component を使うと再帰的なレンダリングも循環インポートにならず簡単に書けて良い
RenderMarkdown
今までは Markdown の render は ArticleRenderer を使っていたが、ArticleRenderer は props として BlogPost を受け取る必要があった。そのため、ブログ以外で Markdown のレンダリングをするのは難しかった。
ブログ以外での Markdown のレンダリングには避難ハッチとして
@/blog/_renderer/getMarkdownOptions
からgetMarkdownOptions
をインポートし、<RemoteMDX source={markdown} {...getMarkdownOptions()} />
していたがかなり最悪である。また、インラインの Markdown のレンダリングには別のコンポーネント RenderInlineMarkdown を使う必要があった。
ここで新しく
RenderMarkdown
を導入し、次のように書けるようにした。Todo
@/components
or@/markdown
に移動@/app/blog/_components
,@/app/blog/[slug]/_components
をまとめるBlogPost
を再設計@/app/blog/_styles.module.css
が複数箇所から参照されてて厳しいので分ける