Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NString value to JSON #7

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix NString value to JSON #7

merged 1 commit into from
Mar 14, 2024

Conversation

t3t5u
Copy link

@t3t5u t3t5u commented Mar 13, 2024 •
edited
Loading

Fix NString value to JSON same as StringColumnSetter.

TODO: Update troccoVersion

@t3t5u t3t5u requested a review from d-hrs March 13, 2024 10:31
d-hrs
d-hrs approved these changes Mar 14, 2024
View reviewed changes
Copy link

@d-hrs d-hrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-hrs d-hrs merged commit 14c07bb into master Mar 14, 2024
8 checks passed
@d-hrs d-hrs deleted the fix/nstring_to_json branch March 14, 2024 01:25
@d-hrs d-hrs mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-hrs d-hrs d-hrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3t5u @d-hrs