Add user-agent parameter to config #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedPython
approved these changes
Aug 7, 2024
chikamura
requested changes
Aug 10, 2024
| @@ -75,6 +90,13 @@ protected JdbcInputConnection newConnection(PluginTask task) throws SQLException | |||
| props.put("ConnSchema", t.getSchemaName().get()); | |||
| } | |||
| props.putAll(t.getOptions()); | |||
| // overwrite UserAgentEntry property if the same property is set in options | |||
| if (t.getUserAgentEntry() != null) { | |||
There was a problem hiding this comment.
t.getUserAgentEntry always seems to be not null.
You might want to delete this line.
There was a problem hiding this comment.
The current code did not guarantee the behavior of 2 below, so changed condition.
- 1: options is not set & user-agent is not set => unknown/0.0.0
- 2: options is set & user-agent is not set => value of options
- 3: options is not set & user-agent is set => value of user-agent
- 4: options is set, user-agent is set => value of user-agent
There was a problem hiding this comment.
We have decided to always overwrite the UserAgentEntry value in options by user-agent, so please ignore the above comment. I removed condition as you commented.
chikamura
reviewed
Aug 10, 2024
Comment on lines
95
to
98
| String product_name = t.getUserAgentEntry().getProductName(); | ||
| String product_version = t.getUserAgentEntry().getProductVersion(); | ||
|
|
||
| props.put("UserAgentEntry", product_name + "/" + product_version); |
There was a problem hiding this comment.
Java's variable names are usually camel case.
product_name -> productName
product_version -> productVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
add optional user-agent parameter