Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/cmake war #40

Merged
merged 12 commits into from
Oct 26, 2023
Merged

feat/cmake war #40

merged 12 commits into from
Oct 26, 2023

Conversation

Samir-Rashid
Copy link
Contributor

  • commit late commit infrequently
  • opencv header works

@Samir-Rashid
Copy link
Contributor Author

image

@Samir-Rashid
Copy link
Contributor Author

Need to resolve linter timeout and docker

@Samir-Rashid
Copy link
Contributor Author

I spoke too soon, this happens in the container.

[100%] Building CXX object CMakeFiles/obcpp.dir/src/main.cpp.o
In file included from /obcpp/src/main.cpp:5:
/obcpp/build/_deps/opencv-src/include/opencv2/opencv.hpp:56:10: fatal error: opencv2/calib3d.hpp: No such file or directory
   56 | #include "opencv2/calib3d.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [CMakeFiles/obcpp.dir/build.make:90: CMakeFiles/obcpp.dir/src/main.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:1553: CMakeFiles/obcpp.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:1560: CMakeFiles/obcpp.dir/rule] Error 2
make: *** [Makefile:189: obcpp] Error 2

@atar13 atar13 self-requested a review October 26, 2023 23:49
Copy link
Member

@atar13 atar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging in only with libtorch working. OpenCV doesn't work perfectly will be addressed in another PR.

@atar13 atar13 merged commit f166071 into main Oct 26, 2023
1 of 2 checks passed
@atar13 atar13 deleted the feat/cmake-war branch December 29, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants