ArenaSDK dependency in CMake #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supported for arm64 or x86 Linux. The ArenaSDK is pulled from our Google Drive since LUCID blocks the SDK behind a login. Once the SDK is downloaded and extracted, CMake adds the necessary include directories and links the relevant libraries. Also modified the json library's CMakeLists.txt file to move library linking to the deps folder. Running target_link_library from a subdirectory requires CMake 3.13, hence the minimum version has been updated. See the section that says "New in version 3.13": https://cmake.org/cmake/help/latest/command/target_link_libraries.html#overview
For some reason, the JSON library's include directory doesn't show up and is manually specified when the lint target is defined. This could be because the JSON project adds it's include directory as an INTERFACE instead of PRIVATE. Therefore, the include directories aren't available by getting the library's INCLUDE_DIRECTORIES target property. https://cmake.org/cmake/help/latest/command/target_include_directories.html
Samir-Rashid
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Successfully got the arena dep.
- can you double check you have gitignored all the new arena stuff?
- NixOS actually doesn't have
/etc/ld.so.conf.d/so I need to something special for that idk yet. Probably will just use the Docker so don't let this block the PR.
All the stuff is downloaded to build/_deps/arena-sdk
I removed the line that modifies the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37
Only supported for arm64 or x86 Linux.
The ArenaSDK is pulled from our Google Drive since LUCID blocks the SDK behind a login.
Once the SDK is downloaded and extracted, CMake adds the necessary include directories and links the relevant libraries.
A macro called "ARENA_SDK_INSTALLED" is enabled if the host is Linux and was able to install the Arena dependencies.
Also modified the json library's CMakeLists.txt file to move library linking to the deps folder.
Running target_link_library from a subdirectory requires CMake 3.13, hence the minimum version has been updated. See the section that says "New in version 3.13": https://cmake.org/cmake/help/latest/command/target_link_libraries.html#overview