CMake UX Improvements #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the OpenCV code to prevent corrupting src and polluting repo from here: https://github.com/opencv/opencv/blob/c96f48e7c91748f896e99f5bf943faf08cd98f0e/CMakeLists.txt#L12 Switched to the JSON cmake specific repo that has a lot of improvements
Samir-Rashid
force-pushed
the
feat/cmake-ux-improvements
branch
from
585f87f to
e522857
Compare
Samir-Rashid
force-pushed
the
feat/cmake-ux-improvements
branch
from
f68da54 to
e293ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent source taint, minimize json dep size
Added the OpenCV code to prevent corrupting src and polluting repo from here:
https://github.com/opencv/opencv/blob/c96f48e7c91748f896e99f5bf943faf08cd98f0e/CMakeLists.txt#L12
Switched to the JSON cmake specific repo that has a lot of improvements
https://github.com/ArthurSonzogni/nlohmann_json_cmake_fetchcontent