Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Interface Designed #25

Merged
merged 9 commits into from
Oct 15, 2023
Merged

Camera Interface Designed #25

merged 9 commits into from
Oct 15, 2023

Conversation

dzodkin33
Copy link
Contributor

No description provided.

@dzodkin33 dzodkin33 requested review from atar13, Tyler-Lentz and Samir-Rashid and removed request for atar13 and Tyler-Lentz October 15, 2023 23:24
@Tyler-Lentz Tyler-Lentz self-requested a review October 15, 2023 23:51
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks amazing, especially the unit tests. Once we switch the tuples to XYZCoords it's definitely ready to merge 👍

EDIT: I'M TROLLINGGGGGGG

@Samir-Rashid Samir-Rashid force-pushed the feature/camera-interface branch from c09a29f to 175d179 Compare October 15, 2023 23:54
@Tyler-Lentz Tyler-Lentz self-requested a review October 15, 2023 23:55
Copy link
Contributor

@Samir-Rashid Samir-Rashid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree wholly with tyler

@dzodkin33 dzodkin33 merged commit 64837fc into main Oct 15, 2023
1 check passed
@Samir-Rashid Samir-Rashid deleted the feature/camera-interface branch October 15, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants