Feat/conn status #156
Merged
Feat/conn status #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atar13
approved these changes
Apr 18, 2024
| @@ -1,11 +1,14 @@ | |||
| // See this page for reference of options: https://containers.dev/implementors/json_reference | |||
| { | |||
| "name": "Existing Dockerfile", | |||
| "image": "ghcr.io/tritonuas/obcpp:x86", | |||
| "image": "ghcr.io/tritonuas/obcpp:main", | |||
| @@ -46,6 +48,11 @@ GCSServer::~GCSServer() { | |||
| } | |||
|
|
|||
| void GCSServer::_bindHandlers() { | |||
| this->server.Get("/", [](const httplib::Request& request, httplib::Response& response) { | |||
| response.status = 200; | |||
| response.set_content("Fort-nite", "text/plain"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR with tritonuas/gcs#121
Information for both here
On the OBC it implements a /connection route and a / route for connection testing purposes for the GCS. It also resets the container to :main because :x86 is currently broken.
On the GCS side of things it implements the obc connection page. There is shit CSS but it displays the info correctly.
Also, it links up the main status indicators on the topbar, but the only one that actually provides meaningful info is the obc one as we aren't really testing connection on the others I think
How To Test / Expected Behavior
Spawn up this branch's obcpp in one terminal.
Pull newest GCS and run
make build-dockerandmake run-composeOpen
localhost:5000in web browserverify that after 2s the OBC connection is green
then visit the OBC connection page and see if it is giving the information (should be all false/null values because nothing is really connected)
Notes
General code quality on the GCS side is very bad. Also the CSS is awful. But It should work.