Airdrop Connection Test #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atar13
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested basic airdrop connection with Cody earlier in the week. This PR fixes two big bugs
Protocol Inconsistency
This PR fixes a bug where the airdrop boards and OBC could get out of sync if an initial ACK_MODE packet was dropped, so the board would miss the initial OBC ack and keep sending SET_MODE packets until the end of time.
Memory access error on malformed packets
Also, this fixes a potential memory access error / seg fault by bounds checking the
dataof a heartbeat packet to make sure that it is within 1-5 before using that value to index into an array.