-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for unix sockets #244
base: main
Are you sure you want to change the base?
Add support for unix sockets #244
Conversation
I am looking into this PR to verify. In the mean time, can you please sign the CLA: https://github.com/triton-inference-server/server/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla |
Thanks @debermudez. I need to check the CLA with my employer. I will get back to you. |
@roger652 After looking into this more, it does not seem that triton server would support unix sockets even with this PR. Can you please attach repro instructions? I want to repro on my end and see what work is necessary to get this fully functional for HTTP atleast. |
The Triton server didn't require any changes to make it run on an unix socket. Steps to reproduce:
|
@roger652 How are you able to get the server operational without the At the moment, this seems to be working on triton server with the caveat that you need to disable metrics. Additionally, I cannot merge this without the signed CLA. Let me know when you have a moment to sign that document and send it over. |
I'm still using an older Triton version (r22.05) and I didn't have the mentioned problem.
I understand. I hope to get the approval to sign the CLA this week. |
@debermudez FYI the CLA is signed. |
Great thank you @roger652. |
We are using Triton with this change in our product. So far we patch Triton manually before building. |
@debermudez Any updates when we can merge this PR? |
Hi @roger652, this PR is currently blocked on a few other changes that are needed in the server side. We'll merge these changes when the server side changes are complete. |
This PR allows to run the Triton HTTP client with an unix domain socket.
The Triton server and client can then be started with an unix domain socket path:
e.g.
-tritonServerHostAndPort=unix:///run/triton.unix