refactoring regexp-pick #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function isRegExp (obj) { |
There was a problem hiding this comment.
This could even be a seperat module.
@tjmehta what do you think?
There was a problem hiding this comment.
I was wondering this too.
Out of curiosity, what is the difference between this and obj instanceof RegExp?
There was a problem hiding this comment.
In this case using instanceof would be okay. It's only a problem if you have different contexts(windows). See i.e. expressjs/express#1557
There was a problem hiding this comment.
Thanks for the instanceof explanation and the refactor, this is much easier to read. Something I need to improve on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion this is much simpler to read.
refs tjmehta/pull/55