Add Envoy support page and update theme #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellemaxwell
commented
Dec 10, 2024
| @@ -1 +1,2 @@ | |||
| .hugo_build.lock | |||
| .hvm | |||
There was a problem hiding this comment.
I installed the hugo version manager to see if that would help me resolve issues with links inside the notice shortcode working.
daniellemaxwell
commented
Dec 10, 2024
| @@ -14,7 +14,6 @@ enableMissingTranslationPlaceholders = false | |||
| [params] | |||
|
|
|||
| # Source Code repository section | |||
| description = "TRISA Documentation" | |||
There was a problem hiding this comment.
This was removed to resolve a build error. An update to the theme required moving the description to _index.en.md. This was previously done, so deleting this line was the only requirement.
daniellemaxwell
commented
Dec 10, 2024
| @@ -7,7 +7,7 @@ weight: 90 | |||
| --- | |||
|
|
|||
| {{% notice style="tip" title="API Credentials" icon="rocket" %}} | |||
| In order to use the API you will have to generate an API Key Client ID and Secret either from the user interface, or by using the command line tool as described in ["creating api keys"]({{< relref "deploy.md#creating-api-keys" >}}). | |||
| In order to use the API you will have to generate an API Key Client ID and Secret either from the user interface, or by using the command line tool as described in ["creating api keys"]({{% relref "deploy.md#creating-api-keys" %}}). | |||
There was a problem hiding this comment.
The change was made after noticing a warning message.
daniellemaxwell
commented
Dec 10, 2024
| ## How can we help? | ||
|
|
||
|
|
||
| | | Open Source | One-Time Setup | Managed Service | |
There was a problem hiding this comment.
This table comes from the Envoy repo's README. If additional information should be included, let me know.
pdamodaran
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Looks good @daniellemaxwell! Thanks for updating the TRISA documentation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of Changes:
This PR adds a page providing details about Envoy support. The Hugo theme was also updated which required a few build errors to be resolved.
Follow on stories were created to continue investigating some warnings that appear when building the site: SC-28640 & SC-28641
Acceptance Criteria:
https://tinyurl.com/2982xtyr