Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group creation with attribute fix #42

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Group creation with attribute fix #42

merged 4 commits into from
Jan 5, 2023

Conversation

acasanova99
Copy link
Collaborator

@acasanova99 acasanova99 commented Dec 27, 2022 •
edited
Loading

Closes #37

  • Removes unused configuration parameter.
  • Separate the group related functions from the client logic. (User and Role functions will be separated from the client eventually)
  • createGroup() allows to create group with attributes. (It is useful to map attributes to the users)
  • new method updateGroup has been added to complete the CRUD functionality of groups
  • GroupRepresentation has been refactor to TrikoraGroupRepresentation which extend from the KC standard GroupRepresentation (User and Role dtos will be enhanced in the same way eventually).

@acasanova99
Copy link
Collaborator Author

Related with #40 and #41.
This MR only covers the group functionality

@jacobdotcosta jacobdotcosta self-requested a review December 29, 2022 16:42
jacobdotcosta
jacobdotcosta approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@jacobdotcosta jacobdotcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobdotcosta jacobdotcosta merged commit 3145d3c into trikorasolns:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobdotcosta jacobdotcosta jacobdotcosta approved these changes

Assignees

@acasanova99 acasanova99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove quarkus.oidc.client.backend-service configuration key if not required
2 participants
@acasanova99 @jacobdotcosta