rewrite arg0_passed tests #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectory hierarchy
squell
force-pushed
the
nit-overhaul-arg0-passing-test
branch
from
470d057
to
1060010
Compare
bjorn3
approved these changes
Nov 28, 2024
bjorn3
reviewed
Dec 2, 2024
| } | ||
| assert_starts_with!(stderr, "foo: unrecognized option"); | ||
| let stderr = output.stderr(); | ||
| assert_starts_with!(stderr, "/nib/sleep:"); |
There was a problem hiding this comment.
Turns out this doesn't actually work on FreeBSD:
---- sudo::path_search::arg0_native_is_passed_from_commandline stdout ----
thread 'sudo::path_search::arg0_native_is_passed_from_commandline' panicked at sudo-compliance-tests/src/sudo/path_search.rs:130:5:
"usage: sleep number[unit] ...\nUnit can be 's' (seconds, the default), m (minutes), h (hours), or d (days)." did not start with "/nib/sleep:"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #735. The test cases we had worked because on modern Debian systems
/binand/usr/binare symlinked. But they made it a bit hard to see what was being tested (and why one of the test cases is ignored--and probably that test case succeeded on FreeBSD).This change alters one of the tests so it should reliably fail with sudo-rs (and so indicate a subtle incompatibility).
Note that this incompatibility is unfixable since sudo-rs uses "realpath" commandmatching whereas ogsudo uses "inode based" matching.