Make it run on FreeBSD #906
Merged
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
It's debatable whether we need a "kernel check" to ensure sudo-rs isn't being run on FreeBSD prior to 8.0. I think we probably don't need this:
- FreeBSD 8.0 is already almost 10 years EOL
- this only gives users a slightly nicer error message and isn't a security feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still a bunch of things that need to be fixed for FreeBSD with some potentially having a security impact, so don't rely on this in production yet. For this reason you need to set
SUDO_RS_IS_UNSTABLEwhen trying to use it on FreeBSD.Together with #904 and #905 this results in:
Part of #869