Increase the amount of benchmark repetitions for decompression to 50 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
that is fine, although for testing, maybe we can have the custom runner take the number of runs too? or think about some other way to easily run benchmarks quickly when we want. |
folkertdev
approved these changes
Jan 22, 2025
|
I think this is too high of a repetition count. The bench job is still running after 15min: https://github.com/trifectatechfoundation/libbzip2-rs/actions/runs/12909389970/job/35996943745 |
bjorn3
force-pushed
the
less_noisy_benchmarking
branch
from
686d58b to
8c4c89f
Compare
bjorn3
changed the title
|
I've lowered the count to 50 such that benchmarking should finish in ~10min. |
bjorn3
force-pushed
the
less_noisy_benchmarking
branch
2 times, most recently
from
9754365 to
7f20690
Compare
bjorn3
changed the title
Benchmarking bzip2 is affected a lot by noise.
bjorn3
force-pushed
the
less_noisy_benchmarking
branch
from
7f20690 to
c465fb0
Compare
|
I'm now only increasing the repetition count for the decompression benchmarks. Now it only slows down benchmarking by about 45s: https://github.com/trifectatechfoundation/libbzip2-rs/actions/runs/12910588311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking bzip2 is affected a lot by noise.