-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New closure methods #131
Open
pricebenjamin
wants to merge
9
commits into
trevorstephens:main
Choose a base branch
from
pricebenjamin:new_closure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New closure methods #131
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3570640
Minor edits to the introduction.
pricebenjamin 706a205
Continuing to clarify the introduction.
pricebenjamin 4d25e7b
Edits to `Evolution` section.
pricebenjamin 325a7ee
Small changes to last few sections of introduction.
pricebenjamin 218a31b
Updated closure for _protected_{division, log, inverse}
pricebenjamin 481fc5b
Remove unnecessary np.errstate context managers
pricebenjamin 511da4b
Cast arguments of _protected_{division, log, inverse} as float64
pricebenjamin f8eaf86
Update expected test result when using new protected functions.
pricebenjamin 70f0c2b
Added testing of protected functions.
pricebenjamin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would mean that results may differ from machine to machine I guess. Don't really like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution still provides the benefit of returning more reasonable values as we approach singularities. I could also then remove the explicit conversion to
np.float64
in the definitions of the protected functions--inputs would be implicity converted upon addition of_EPS
. Testing of protected functions would need to be updated with lower tolerance.