Message importance #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
ricardoboss
reviewed
Oct 8, 2024
TRENZ.Lib.RazorMail.SystemNet/Extensions/SystemNetMailMessageExtensions.cs
Show resolved
Hide resolved
added 2 commits
October 14, 2024 16:33
chucker
force-pushed
the
feature/message-priority
branch
from
5f2bc94
to
2298da0
Compare
ricardoboss
requested changes
Nov 19, 2024
| /// <summary> | ||
| /// The keys for the mail addresses in the collection. | ||
| /// </summary> | ||
| public static readonly string[] AddressKeys = [ToKey, CcKey, BccKey, ReplyToKey, FromKey]; | ||
|
|
||
| /// <summary> | ||
| /// Keys for headers that the <see cref="BaseSmtpMailClient"/> |
There was a problem hiding this comment.
Either fully qualify the cref oder add a using statement
| .ExceptBy(AddressKeys, x => x.Key) | ||
| .ToDictionary(x => x.Key, x => x.Value); | ||
|
|
||
| /// <summary> | ||
| /// Gets the headers that the <see cref="BaseSmtpMailClient"/> implementation should just iterate over. |
There was a problem hiding this comment.
Also here, fully qualify or using
|
Also in MailHeaderCollection in line 213: Switch from |
ricardoboss
reviewed
Nov 19, 2024
| @@ -185,7 +185,7 @@ public void AddBlindCarbonCopy(IEnumerable<MailAddress> addresses) => | |||
| /// Gets the headers that are not mail addresses and therefore have no getter/setter. | |||
| /// </summary> | |||
| [Obsolete("This will be removed in a future version.")] | |||
| public IReadOnlyDictionary<string, object> NonAddressHeaders => this | |||
| private IReadOnlyDictionary<string, object> NonAddressHeaders => this | |||
There was a problem hiding this comment.
Well... if we change the API, it is a breaking change. I'd have favoured a minor release (since it is already marked obsolete). If we make this change, we can outright just remove the property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #15.
I'm not implementing mail transfer priority here, because usage seems low.