Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Add support for NXAST_LEARN #298

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions features/open_flow13/nicira_learn.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
@openflow13
Feature: NiciraLearn

This action adds or modifies a flow in an OpenFlow table, similar to
OFPT_FLOW_MOD with OFPFC_MODIFY_STRICT as 'command'.

Scenario: new({})
When I try to create an OpenFlow action with:
"""
Pio::OpenFlow::NiciraLearn.new({})
"""
Then it should finish successfully
And the action has the following fields and values:
| field | value |
| idle_timeout | 0 |
| hard_timeout | 0 |
| priority | 65535 |
| cookie | 0 |
| flags | [] |
| table_id | 0 |
| fin_idle_timeout | 0 |
| fin_hard_timeout | 0 |
1 change: 1 addition & 0 deletions lib/pio/open_flow13.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
require 'pio/open_flow13/nicira_send_out_port'
require 'pio/open_flow13/nicira_stack_pop'
require 'pio/open_flow13/nicira_stack_push'
require 'pio/open_flow13/nicira_learn'
require 'pio/open_flow13/send_out_port'
require 'pio/open_flow13/set_arp_operation'
require 'pio/open_flow13/set_arp_sender_hardware_address'
Expand Down
26 changes: 26 additions & 0 deletions lib/pio/open_flow13/nicira_flow_mod_specs.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
module Pio
module OpenFlow13
# OpenFlow 1.3 FlowModSpecs
class NiciraFlowModSpecs < BinData::Primitive
endian :big

count_bytes_remaining :instructions_length
string :instructions, read_length: :instructions_length

def set(instructions)
self.instructions = Array(instructions).map(&:to_binary_s).join
end

def get
list = []
tmp = instructions
list << instruction while tmp.length > 0
list
end

def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use delegate to define delegations.

instructions.length
end
end
end
end
41 changes: 41 additions & 0 deletions lib/pio/open_flow13/nicira_learn.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
require 'pio/open_flow'

module Pio
module OpenFlow13
# NXAST_LEARN action
class NiciraLearn < OpenFlow::NiciraAction
extend OpenFlow::Flags

flags_16bit :flags, [:send_flow_rem,
:delete_learned]

nicira_action_header action_type: 0xffff,
action_length: 24,
subtype: 16
uint16 :idle_timeout
uint16 :hard_timeout
uint16 :priority, initial_value: 0xffff
uint64 :cookie
flags :flags
uint8 :table_id
string :padding1, length: 1
hide :padding1
uint16 :fin_idle_timeout
uint16 :fin_hard_timeout
string :padding2, length: 2
hide :padding2

def fms_length
if flow_mod_specs.size > 0
flow_mod_specs.map(&:length).inject(&:+)
else
0
end
end

def padding_length
(22 + 7) / 8 * 8 - 22
end
end
end
end