Refactor chart plotting #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treiher
requested changes
Nov 22, 2024
senier
force-pushed
the
refactor_chart_plotting
branch
from
7cfbb02 to
3c3801f
Compare
senier
force-pushed
the
refactor_chart_plotting
branch
from
3c3801f to
f9c9e85
Compare
senier
force-pushed
the
refactor_chart_plotting
branch
2 times, most recently
from
f51152e to
1385a66
Compare
treiher
reviewed
Nov 24, 2024
senier
force-pushed
the
refactor_chart_plotting
branch
3 times, most recently
from
b0ead6c to
0971c15
Compare
treiher
reviewed
Nov 27, 2024
treiher
requested changes
Nov 27, 2024
senier
force-pushed
the
refactor_chart_plotting
branch
from
0971c15 to
7112fe2
Compare
senier
force-pushed
the
refactor_chart_plotting
branch
from
7112fe2 to
c5a4a0b
Compare
treiher
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation of the changes discussed in #63.
The chart plotting functions got refactored to remove code duplication and make plotting more flexible. Plots can now be done as lines, circles or histograms in any combination on the primary as well as the secondary axis (or both at once).
Plots should look exactly the same as before (this appears to be true for demo data as well as my real world data).
Additionally: