FIXUP: Apply suggestions from code review

Co-authored-by: Tobias Reiher <[email protected]>
treiher · Dec 2, 2024 · 8b86b87 · 8b86b87
1 parent 8d4c695
commit 8b86b87
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/frontend/src/ui/page/muscles.rs b/frontend/src/ui/page/muscles.rs
@@ -73,8 +73,8 @@ pub fn view(model: &Model, data_model: &data::Model) -> Node<Msg> {
                 let total_7day_set_volume = common::centered_moving_total(
                     &data_model
                         .training_sessions
-                        .iter()
-                        .filter_map(|(_, s)| {
+                        .values()
+                        .filter_map(|s| {
                             s.stimulus_per_muscle(&data_model.exercises)
                                 .get(&domain::Muscle::id(*m))
                                 .map(|stimulus| (s.date, *stimulus as f32 / 100.))
@@ -98,7 +98,7 @@ pub fn view(model: &Model, data_model: &data::Model) -> Node<Msg> {
                             &[common::PlotData {
                                 values: total_7day_set_volume,
                                 plots: common::plot_line(common::COLOR_SET_VOLUME),
-                                params: common::PlotParams::default(),
+                                params: common::PlotParams::primary_range(0., 10.),
                             }],
                             model.interval.first,
                             model.interval.last,

diff --git a/frontend/src/ui/page/training.rs b/frontend/src/ui/page/training.rs
@@ -246,8 +246,8 @@ pub fn view(model: &Model, data_model: &data::Model) -> Node<Msg> {
         let average_7day_rpe = common::centered_moving_average(
             &data_model
                 .training_sessions
-                .iter()
-                .filter_map(|(_, s)| s.avg_rpe().map(|v| (s.date, v)))
+                .values()
+                .filter_map(|s| s.avg_rpe().map(|v| (s.date, v)))
                 .collect::<Vec<_>>(),
             &model.interval,
             3,
@@ -562,7 +562,7 @@ pub fn view_charts<Ms>(
             common::plot_chart(
                 &[common::PlotData {
                     values: total_7day_set_volume,
-                    plots: [common::PlotType::Line(common::COLOR_SET_VOLUME, 2)].to_vec(),
+                    plots: common::plot_line(common::COLOR_SET_VOLUME)),
                     params: common::PlotParams::primary_range(0., 10.),
                 }],
                 interval.first,