Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental flag to StorageID #8535

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add experimental flag to StorageID #8535

merged 2 commits into from
Jan 21, 2025

Conversation

itaigilo
Copy link
Contributor

No description provided.

@itaigilo itaigilo added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached msb labels Jan 21, 2025
@itaigilo itaigilo requested a review from a team January 21, 2025 18:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

♻️ PR Preview 6c3336c has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

E2E Test Results - Quickstart

11 passed

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

N-o-Z
N-o-Z requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same convention we have for experimental parameters in swagger (see hidden branch parameter)

@itaigilo itaigilo requested a review from N-o-Z January 21, 2025 18:53
N-o-Z
N-o-Z approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itaigilo itaigilo merged commit bc34eeb into master Jan 21, 2025
40 checks passed
@itaigilo itaigilo deleted the task/add-experimental-flag-to-storage-id branch January 21, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees
No one assigned
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached msb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itaigilo @N-o-Z