Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Background
Currently, the WebUI Users page displays the list of users, as fetched from the server.
The issue is that the server sorts the users by their
id
, while the UI is displaying the User ID for each user using a more complex logic (email
=>friendly_name
=>id
).This creates a confusing situation: where some users has emails while others don't have, the sorting might be messed up.
For example:
List of users:
Actual display:
Change
This PR aligns the display order to be sorted according to the displayed
User ID
.Testing Details
Tested manually on my local env.
Additional info
Note that this is not a complete solution, since the UI uses pagination.
But it should at least improve the current state, and make it easier to find users on the current results page.
A complete solution will require a bigger change to support it, which will probably involve both changing the UI and change the default sorting of the API.