Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WebUI users sort #8421

Closed
wants to merge 1 commit into from
Closed

Conversation

itaigilo
Copy link
Contributor

@itaigilo itaigilo commented Dec 13, 2024

Change Description

Background

Currently, the WebUI Users page displays the list of users, as fetched from the server.
The issue is that the server sorts the users by their id, while the UI is displaying the User ID for each user using a more complex logic (email => friendly_name => id).
This creates a confusing situation: where some users has emails while others don't have, the sorting might be messed up.

For example:

List of users:

[
  {id: 'ccc`},
  {id: 'zzz', email: '[email protected]'} 
]

Actual display:

User ID
-------
ccc
[email protected]

Change

This PR aligns the display order to be sorted according to the displayed User ID.

Testing Details

Tested manually on my local env.

Additional info

Note that this is not a complete solution, since the UI uses pagination.
But it should at least improve the current state, and make it easier to find users on the current results page.

A complete solution will require a bigger change to support it, which will probably involve both changing the UI and change the default sorting of the API.

@itaigilo itaigilo added area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels Dec 13, 2024
Copy link

E2E Test Results - Quickstart

11 passed

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@itaigilo
Copy link
Contributor Author

Closing as #8413 already handles this one.

@itaigilo itaigilo closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant