HL Python SDK: Fix Client SSL configuration #7516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
bug
|
♻️ PR Preview d1261af has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
idanovo
reviewed
Feb 26, 2024
Comment on lines
+54
to
+57
| if verify_ssl is not None: | ||
| self.verify_ssl = verify_ssl | ||
| if proxy is not None: | ||
| self.proxy = proxy |
There was a problem hiding this comment.
Suggested change
| if verify_ssl is not None: | |
| self.verify_ssl = verify_ssl | |
| if proxy is not None: | |
| self.proxy = proxy | |
| if verify_ssl: | |
| self.verify_ssl = verify_ssl | |
| if proxy: | |
| self.proxy = proxy |
There was a problem hiding this comment.
@idanovo Thanks, note that this is a common mistake in python:
if verify_ssl will return False if verify_ssl is None or False.
In this case we want to assign the values only if they are not None (i.e. passed explicitly) whether they are True or False, and if not passed (or None) fallback to the client default settings.
In general the convention in python is to always use is not None to avoid logical mistakes when checking if value exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7513
Change Description
Propagate ssl configuration properly to the lakeFS client
Background
The lakeFS configuration is updated dynamically, but unfortunately once the client is initialized, it initializes the underlying RESTClient with the initial values.
This in addition to the fact that the auto generated configuration class does not provide passing the ssl state and proxy configurations.
Bug Fix
ClientConfig to inherit from SDK Configuration class, and load the additional configuration on it.
Updated documentation accordingly
Testing Details
Added sanity test