Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Wrapper: Allow passing args/kwargs to lakefs.repository() #7470

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Python Wrapper: Allow passing args/kwargs to lakefs.repository() #7470

merged 1 commit into from
Feb 20, 2024

Conversation

ozkatz
Copy link
Collaborator

@ozkatz ozkatz commented Feb 16, 2024

Main use case - support adding a custom client:

>>> import lakefs
>>> from lakefs.client import Client
>>> c = Client(...)
>>> repo = lakefs.repository('foo', client=c)

This currently requires another import in order to initialize a lakefs.repository.Repository

@ozkatz ozkatz added include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached python-wrapper labels Feb 16, 2024
@ozkatz ozkatz requested a review from N-o-Z February 16, 2024 11:29
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

10 passed

N-o-Z
N-o-Z approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozkatz ozkatz merged commit b225fd7 into master Feb 20, 2024
41 checks passed
@ozkatz ozkatz deleted the er/python-repo-kwargs branch February 20, 2024 15:32
@N-o-Z N-o-Z added python-sdk-changelog and removed include-changelog PR description should be included in next release changelog labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees
No one assigned
Labels
minor-change Used for PRs that don't require issue attached python-sdk-changelog python-wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozkatz @N-o-Z