Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code-migrate-1.0-sdk.md #6843

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Update code-migrate-1.0-sdk.md #6843

merged 1 commit into from
Oct 23, 2023

Conversation

itaiad200
Copy link
Contributor

No description provided.

@itaiad200 itaiad200 added the bug Something isn't working label Oct 23, 2023
@itaiad200 itaiad200 requested a review from nopcoder October 23, 2023 18:29
@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

♻️ PR Preview db478b6 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

nopcoder
nopcoder approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that the lakefs client also have the _api properties. the non API was dropped in the new SDK.

@itaiad200 itaiad200 added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Oct 23, 2023
@itaiad200
Copy link
Contributor Author

note that the lakefs client also have the _api properties. the non API was dropped in the new SDK.

Thanks! I still think it's better the example has the biggest 'diff' possible for the migration.

@itaiad200 itaiad200 merged commit fc8fddc into master Oct 23, 2023
32 of 36 checks passed
@itaiad200 itaiad200 deleted the docs/fix-python-code branch October 23, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

Assignees
No one assigned
Labels
bug Something isn't working exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itaiad200 @nopcoder