with docs

treeverse · Dec 24, 2024 · acc4cc7 · acc4cc7
1 parent d9a5387
commit acc4cc7
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/pkg/block/s3/client_cache.go b/pkg/block/s3/client_cache.go
@@ -142,6 +142,7 @@ func (c *ClientCache) cachedClientByRegion(region string) (*s3.Client, bool) {
 
 func (c *ClientCache) refreshBucketRegion(ctx context.Context, bucket string) string {
 	region, err := c.s3RegionGetter(ctx, bucket)
+	// error can be nil also in case region is empty
 	if err != nil || region == "" {
 		// fallback to default region
 		region = c.awsConfig.Region