-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to add additional labels to lakefs pod #299
base: master
Are you sure you want to change the base?
Conversation
@wadhah101 thank you for opening this PR! |
@wadhah101 added description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for drafting this. Please bump Chart.yaml
@Isan-Rivkin Bumped to 1.3.26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thanks for drafting this PR!
The issue with this change is that K8S does not allow duplicate keys in labels.
Add a duplicate key such as app
to podLabels
yourself you'll see.
For me it breaks when I add podLabel app=duplicate
I run helm install with the error
The Deployment "lakefs" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"app":"duplicate", "app.kubernetes.io/instance":"lakefs", "app.kubernetes.io/name":"lakefs"}: `selector` does not match template `labels`
kubectl version (on EKS):
Client Version: v1.29.0
Server Version: v1.30.7
So first, can you please better explain your use-case, is it specifically pod labels or Deployment labels? is it specifically override specific label keys? Should this affect the labelSelector?
What is it you would like to achieve.
Second incase of override label keys, I'd go with an override all-or-nothing approach not appending to existing labels.
In certain cases you want to override the pod labels.
example : adding azure.workload.identity/use=true in https://learn.microsoft.com/en-us/azure/aks/workload-identity-overview?tabs=dotnet#pod-labels
this pr adds the option to specify labels