Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scanner): simplify string logic #21

Merged
merged 1 commit into from
May 10, 2024

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented May 10, 2024

Closes #20

@cdacamar can you try this branch out and see if you still get the inconsistent parsing behavior?

I believe the issue stems from asan hooking and changing strcmp, and I'm assuming the windows implementation is similar to this one, or at the very least not like the typical glibc strcmp - hence the extremely bizarre inconsistency. I noticed that the external lexer was not returning the ending tag name after lexing it, which was weird. So I changed the string logic to be simpler and more akin to html's, seems to be good on my end

@amaanq amaanq changed the title fix: simplify string logic fix(scanner): simplify string logic May 10, 2024
@cdacamar
Copy link

I just tested this branch out: everything works on both MSVC and clang-cl (with and without -fsanitize=adderss).

Thank you!

@amaanq amaanq merged commit 8cd508b into tree-sitter-grammars:master May 10, 2024
5 checks passed
@amaanq
Copy link
Member Author

amaanq commented May 10, 2024

np, glad it's fixed! and thanks for the helpful report

@ObserverOfTime
Copy link
Member

That's a Heisenbug if I've ever seen one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: longer XML tags are errors
3 participants