fix(scanner): simplify string logic #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
@cdacamar can you try this branch out and see if you still get the inconsistent parsing behavior?
I believe the issue stems from asan hooking and changing strcmp, and I'm assuming the windows implementation is similar to this one, or at the very least not like the typical glibc strcmp - hence the extremely bizarre inconsistency. I noticed that the external lexer was not returning the ending tag name after lexing it, which was weird. So I changed the string logic to be simpler and more akin to html's, seems to be good on my end