feat: move delimiter parsing to the scanner #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObserverOfTime
force-pushed
the
delim
branch
3 times, most recently
from
67a0442 to
a2e446a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ObserverOfTime
force-pushed
the
delim
branch
4 times, most recently
from
68c807c to
a807091
Compare
Co-Authored-By: ObserverOfTime <[email protected]>
|
Further improvements can be made if and when necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs more tests, also
ts t -uremoves the extra delimiter which needs to be fixed upstream