Support dot-prefixed predicates and MISSING keyword #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restricts identifiers to not start with "." and also allows predicates to be denoted with "." as well as "#", as specified by `query.c`. See https://github.com/tree-sitter/tree-sitter/blob/9c8055765849eee39f69a8eda7d2a5aede2b2e60/lib/src/query.c#L2308 and https://github.com/emacs-tree-sitter/tree-sitter-langs/blob/b955ffbe26b3a7e931f116720efa7dee9de35174/queries/hcl/highlights.terraform-mode.scm#L13
ribru17
changed the title
ribru17
force-pushed
the
dotted_preds
branch
from
c9bcc04 to
396dd05
Compare
amaanq
approved these changes
Dec 16, 2024
ribru17
force-pushed
the
dotted_preds
branch
from
396dd05 to
88a41a2
Compare
Since tree-sitter/tree-sitter#3887, query files support a MISSING keyword to match against missing nodes. This updates the grammar to allow for such a syntax.
ribru17
force-pushed
the
dotted_preds
branch
from
88a41a2 to
3bf2606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricts identifiers to not start with "." and also allows predicates to be denoted with "." as well as "#", as specified by
query.c.See https://github.com/tree-sitter/tree-sitter/blob/9c8055765849eee39f69a8eda7d2a5aede2b2e60/lib/src/query.c#L2308 and https://github.com/emacs-tree-sitter/tree-sitter-langs/blob/b955ffbe26b3a7e931f116720efa7dee9de35174/queries/hcl/highlights.terraform-mode.scm#L13
Since tree-sitter/tree-sitter#3887, query files
support a
MISSINGkeyword to match against missing nodes. This updatesthe grammar to allow for such a syntax.