Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle IMEIs shorter than 15 digits #49

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

RoadRunnr
Copy link
Member

IMEIs are 15 digits and IMEI-SVs are 16 digits (3GPP TS 23.003, clause 6.2), anything else is not a valid IMEI. However, somehow 14 digit values are observed in the wild. Make sure that encoder/decoder handles them, so that higher levels can deal with the values.

(cherry picked from commit f69e2ff)

@RoadRunnr RoadRunnr requested a review from a team as a code owner September 6, 2024 06:50
IMEIs are 15 digits and IMEI-SVs are 16 digits (3GPP TS 23.003, clause
6.2), anything else is not a valid IMEI. However, somehow 14 digit
values are observed in the wild. Make sure that encoder/decoder
handles them, so that higher levels can deal with the values.

(cherry picked from commit f69e2ff)
@RoadRunnr RoadRunnr force-pushed the feature/stable/3.x/safe-imei-encoding branch from ed4f436 to 1028d87 Compare September 6, 2024 07:40
Copy link

github-actions bot commented Sep 6, 2024

Test Results

 11 files  ± 0   11 suites  ±0   27s ⏱️ ±0s
 14 tests + 1   14 ✅ + 1  0 💤 ±0  0 ❌ ±0 
132 runs  +11  132 ✅ +11  0 💤 ±0  0 ❌ ±0 

Results for commit 1028d87. ± Comparison against base commit 38b86ff.

@coveralls
Copy link

Coverage Status

coverage: 69.008% (-0.2%) from 69.249%
when pulling 1028d87 on feature/stable/3.x/safe-imei-encoding
into 38b86ff on stable/3.x.

@RoadRunnr RoadRunnr merged commit 8029016 into stable/3.x Sep 6, 2024
12 of 18 checks passed
@RoadRunnr RoadRunnr deleted the feature/stable/3.x/safe-imei-encoding branch September 6, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants