Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed compact range support #287

Merged

Conversation

mhutchinson
Copy link
Contributor

Witness no longer supports compact ranges for logs. This fixes #286.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 27.86885% with 44 lines in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (3c58af4) to head (932f536).
Report is 127 commits behind head on main.

Files with missing lines Patch % Lines
internal/feeder/sumdb/sumdb_feeder.go 0.00% 31 Missing ⚠️
internal/persistence/sql/sql.go 72.72% 3 Missing ⚠️
internal/witness/witness.go 50.00% 0 Missing and 3 partials ⚠️
omniwitness/configs.go 0.00% 3 Missing ⚠️
internal/client/sumdb.go 0.00% 2 Missing ⚠️
internal/persistence/testonly/persistence.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #287       +/-   ##
===========================================
- Coverage   51.05%   27.11%   -23.94%     
===========================================
  Files          11       23       +12     
  Lines         903     1630      +727     
===========================================
- Hits          461      442       -19     
- Misses        374     1109      +735     
- Partials       68       79       +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhutchinson mhutchinson force-pushed the compactRangeRedundancy branch from b938a6d to 8ede2d1 Compare October 24, 2024 08:23
Towards transparency-dev#286.

This commit removes compact range support from the sumdb feeder and the witness itself. This effectively removes compact range support, but there is still cleanup to do.
@mhutchinson mhutchinson force-pushed the compactRangeRedundancy branch from 8ede2d1 to 932f536 Compare November 5, 2024 17:11
@mhutchinson mhutchinson merged commit ac65be9 into transparency-dev:main Nov 5, 2024
8 checks passed
@mhutchinson mhutchinson deleted the compactRangeRedundancy branch November 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove witness support for compact ranges
3 participants