Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeders push checkpoints even if they are equivalent #283

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mhutchinson
Copy link
Contributor

The feeder previously short circuited if the witness had already witnessed an equivalent checkpoint. This meant that logs would get stale timestamps from the witnesses. This change makes it so that the witness will keep updating their timestamps on checkpoints.

The feeder previously short circuited if the witness had already witnessed an equivalent checkpoint. This meant that logs would get stale timestamps from the witnesses. This change makes it so that the witness will keep updating their timestamps on checkpoints.
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 31.30%. Comparing base (3c58af4) to head (c57c23a).
Report is 119 commits behind head on main.

Files with missing lines Patch % Lines
internal/feeder/feeder.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #283       +/-   ##
===========================================
- Coverage   51.05%   31.30%   -19.75%     
===========================================
  Files          11       23       +12     
  Lines         903     1757      +854     
===========================================
+ Hits          461      550       +89     
- Misses        374     1109      +735     
- Partials       68       98       +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhutchinson mhutchinson merged commit b7bae3c into transparency-dev:main Oct 22, 2024
8 checks passed
@mhutchinson mhutchinson deleted the feederFeedsStaleFood branch October 22, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants