Perform witness signing on checkpoints of the same size #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a short circuit that previously skipped doing work if the tree at that size had previously been witnessed. Having fresh timestamps on checkpoints is a feature.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
===========================================
- Coverage 51.05% 33.57% -17.48%
===========================================
Files 11 23 +12
Lines 903 1382 +479
===========================================
+ Hits 461 464 +3
- Misses 374 821 +447
- Partials 68 97 +29 ☔ View full report in Codecov by Sentry. |
AlCutter
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a short circuit that previously skipped doing work if the tree at that size had previously been witnessed. Having fresh timestamps on checkpoints is a feature.