Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sequenced entries to entry bundles in MySQL storage implementation #94

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

roger2hk
Copy link
Contributor

#21

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 31.59%. Comparing base (46ec9c2) to head (642d8e0).
Report is 16 commits behind head on main.

Files Patch % Lines
storage/mysql/mysql.go 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   35.80%   31.59%   -4.21%     
==========================================
  Files          16       16              
  Lines        1363     1538     +175     
==========================================
- Hits          488      486       -2     
- Misses        801      978     +177     
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roger2hk roger2hk force-pushed the mysql-write-entry-bundle branch from c3a4cdd to 9f53fc4 Compare July 29, 2024 12:28
storage/mysql/mysql.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to see some in-memory SQL tests for this soon.

storage/mysql/mysql.go Show resolved Hide resolved
@roger2hk
Copy link
Contributor Author

It would be great to see some in-memory SQL tests for this soon.

Sure, I will add the tests this week.

@roger2hk roger2hk merged commit dc6905e into transparency-dev:main Jul 29, 2024
5 checks passed
@roger2hk roger2hk deleted the mysql-write-entry-bundle branch July 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants