Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pushback on GCP #92

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

AlCutter
Copy link
Collaborator

This PR adds a simple pushback implementation for GCP.

This enables a configurable threshold for applying back-pressure when there are too many
as-yet unintegrated entries.

Toward #6 #23

@AlCutter AlCutter force-pushed the gcp_pushback branch 3 times, most recently from b9b5532 to ab5301f Compare July 26, 2024 16:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 32.20%. Comparing base (46ec9c2) to head (51134bd).
Report is 14 commits behind head on main.

Files Patch % Lines
storage/gcp/gcp.go 44.44% 7 Missing and 3 partials ⚠️
cmd/example-gcp/main.go 0.00% 4 Missing ⚠️
log.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   35.80%   32.20%   -3.60%     
==========================================
  Files          16       16              
  Lines        1363     1509     +146     
==========================================
- Hits          488      486       -2     
- Misses        801      949     +148     
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/example-gcp/main.go Outdated Show resolved Hide resolved
@AlCutter AlCutter merged commit a2b1b7c into transparency-dev:main Jul 29, 2024
5 checks passed
@AlCutter AlCutter deleted the gcp_pushback branch July 29, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants