Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WithBatching in GCP #91

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

AlCutter
Copy link
Collaborator

This PR enables support of WithBatching in the GCP storage.

Toward #23

@AlCutter AlCutter requested a review from phbnf July 25, 2024 17:07
@AlCutter AlCutter changed the title Support WithBatching in GCP. Support WithBatching in GCP Jul 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 32.19%. Comparing base (46ec9c2) to head (cc34fad).
Report is 13 commits behind head on main.

Files Patch % Lines
cmd/example-gcp/main.go 0.00% 4 Missing ⚠️
log.go 0.00% 2 Missing ⚠️
storage/gcp/gcp.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   35.80%   32.19%   -3.62%     
==========================================
  Files          16       16              
  Lines        1363     1491     +128     
==========================================
- Hits          488      480       -8     
- Misses        801      939     +138     
+ Partials       74       72       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlCutter AlCutter merged commit 6c96fb4 into transparency-dev:main Jul 26, 2024
5 checks passed
@AlCutter AlCutter deleted the gcp_use_options branch July 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants