Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posix log implementation of tlog-tiles #67

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

mhutchinson
Copy link
Contributor

@mhutchinson mhutchinson commented Jul 17, 2024

This is largely a copy and paste job from both the experimental Betty repo and from serverless. The primary motivation to have this posix implementation right now is to generate test data, such as that used in #49.

There has been little in the way of optimization. The primary concern was minimal code changes in order to get a working posix log to generate test data.

Towards #22

@mhutchinson mhutchinson force-pushed the log-posix branch 5 times, most recently from e9df989 to cafffcc Compare July 18, 2024 09:17
- /storage/posix:
  - Files are from Betty /storage/posix and /log/writer/
- /cmd/example-posix:
  - Files are from serverless-log /cmd/sequence

This doesn't build, but is included in the history to
show a useful diff for reviewing.
@mhutchinson mhutchinson marked this pull request as ready for review July 23, 2024 08:23
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review since most of this code was already reviewed in serverless.

Just the one thing inline stuck out.

cmd/example-posix/main.go Outdated Show resolved Hide resolved
@mhutchinson mhutchinson merged commit 4b92e94 into transparency-dev:main Jul 23, 2024
4 checks passed
@mhutchinson mhutchinson deleted the log-posix branch July 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants