Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect parseTileLevelIndexWidth implementation and add tests #56

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix incorrect parseTileLevelIndexWidth implementation and add tests #56

merged 2 commits into from
Jul 11, 2024

Conversation

roger2hk
Copy link
Contributor

#21

@roger2hk roger2hk requested a review from mhutchinson July 10, 2024 22:34
mhutchinson
mhutchinson approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do the tests :-)

There are a couple of comments to be addressed, but I trust that the fixes won't need a re-review. Feel free to ask if you'd like one though.

cmd/example-mysql/main.go Show resolved Hide resolved
cmd/example-mysql/main.go Outdated Show resolved Hide resolved
cmd/example-mysql/main.go Outdated Show resolved Hide resolved
@roger2hk roger2hk changed the title FIx incorrect parseTileLevelIndexWidth implementation and add tests Fix incorrect parseTileLevelIndexWidth implementation and add tests Jul 11, 2024
@roger2hk roger2hk merged commit 597a568 into transparency-dev:main Jul 11, 2024
4 checks passed
@roger2hk roger2hk deleted the mysql-parse-tile branch July 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

Assignees

@mhutchinson mhutchinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roger2hk @mhutchinson